looks ok to me
Sun
On Sat, Feb 12, 2011 at 11:51 AM, Jian-Xin Lai <laij...@gmail.com> wrote:
> Hi,
>
> Could a gate keeper review the patch to bug710? Thank you very much.
>
> Index: common/com/x8664/targ_sim.cxx
> ===================================================================
>
> --- common/com/x8664/targ_sim.cxx (revision 1285)
> +++ common/com/x8664/targ_sim.cxx (working copy)
> @@ -214,7 +214,7 @@
> classes[i] = X86_64_NO_CLASS;
> if (TY_kind(ty) == KIND_STRUCT ||
> TY_kind(ty) == KIND_ARRAY) {
>
> - if (TY_kind(ty) == KIND_STRUCT) {
> + if (TY_kind(ty) == KIND_STRUCT && Ty_Table[ty].Fld()) {
> FLD_ITER fld_iter = Make_fld_iter(TY_fld(ty));
> do {
> FLD_HANDLE fld(fld_iter);
>
> This patch is prepared by Rajiv. The segmentation occurs when we are trying
> to visit the field info of an empty struct. The patch will check if the
> field info are available before visit them.
>
> --
> Regards,
> Lai Jian-Xin
>
> ------------------------------------------------------------------------------
> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> Pinpoint memory and threading errors before they happen.
> Find and fix more than 250 security defects in the development cycle.
> Locate bottlenecks in serial and parallel code that limit performance.
> http://p.sf.net/sfu/intel-dev2devfeb
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
