This patch looks good. Please go ahead.
2011/2/22 David Coakley <dcoak...@gmail.com>
> When I made changes to the targ_info SI generator last month, I
> unintentionally introduced a bug in the Makefile. The buggy rule is:
>
> targ_si.c targ_si.h: targ_si_gen
> $(run) ./targ_si_gen
>
> What I meant to say is "running targ_si_gen once generates both
> targ_si.c and targ_si.h", but this rule really says to run the
> generator once for each target. With 'make -j' sometimes the two runs
> of the generator could interfere. (Thanks to Yong-Chong Wu for
> pointing out the problem!)
>
> In other places in the Makefile, a similar problem is solved by
> claiming that the C file depends on the header file and that the
> generator only produces the header file. Although this form works in
> practice, it does not really convey the fact that the generator also
> writes the C file. The solution I prefer uses pattern rules, as these
> are the documented way to handle the case where a single recipe
> generates multiple targets (see
> http://www.gnu.org/software/make/manual/make.html#Pattern-Intro). The
> pattern rule can be written:
>
> tar%_si.c tar%_si.h: targ_si_gen
> $(run) ./targ_si_gen
>
> The attached patch changes all the generator rules in the targ_info
> Makefile to follow this pattern, fixing the buggy rule for
> targ_si.[ch] along the way.
>
> Could a gatekeeper please review it?
>
> -David Coakley / AMD Open Source Compiler Engineering
>
>
> ------------------------------------------------------------------------------
> Index, Search & Analyze Logs and other IT data in Real-Time with Splunk
> Collect, index and harness all the fast moving IT data generated by your
> applications, servers and devices whether physical, virtual or in the
> cloud.
> Deliver compliance at lower cost and gain new business insights.
> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Index, Search & Analyze Logs and other IT data in Real-Time with Splunk
Collect, index and harness all the fast moving IT data generated by your
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights.
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
