pls go ahead
Sun
On Sun, Feb 27, 2011 at 6:31 PM, Jian-Xin Lai <laij...@gmail.com> wrote:
> Hi,
>
> Could a gate keeper review the patch to fix the bugs in WHIRL CFG? Thank you
> very much.
> Index: ../com/wn_cfg_template.h
> ===================================================================
> --- ../com/wn_cfg_template.h (revision 1327)
> +++ ../com/wn_cfg_template.h (working copy)
> @@ -748,7 +748,6 @@
> Is_True(wn != NULL && WN_operator(wn) == OPR_ALTENTRY,
> ("WN is not ALTENTRY"));
> Is_True(_current_bb != NULL, ("Current BB is NULL"));
> - Is_True(_current_bb->Get_preds_count() == 0, ("Current BB has
> predecessors"));
>
> _current_bb = _action.Create_node(NULL, wn);
> _action.Process_entry_node(_current_bb);
> @@ -1093,8 +1092,10 @@
> }
>
> // create and connect BB1
> - _current_bb = _action.Create_node(condgoto_bb, WN_next(wn));
> - _action.Process_predsucc(condgoto_bb, _current_bb);
> + if (WN_next(wn) != NULL) {
> + _current_bb = _action.Create_node(condgoto_bb, WN_next(wn));
> + _action.Process_predsucc(condgoto_bb, _current_bb);
> + }
> }
>
> //===================================================================
>
> The first change is about the assertion of the number of the predecessors of
> an ALTENTRY. This assertion is wrong since the ALTENTRY has a predecessor,
> which is the dummy entry of the CFG.
> The second one is for FALSEBR/TRUEBR. If their next WN is NULL, we don't
> need to create new BB.
>
> --
> Regards,
> Lai Jian-Xin
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT
> data
> generated by your applications, servers and devices whether physical,
> virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
