May be use consistent iterator or iter or something throughout the entire wssa code Sun
On Sat, Mar 5, 2011 at 7:21 AM, Ye, Mei <mei...@amd.com> wrote: > Hi Jian-Xin > > Looks good to me. The name of “dfs_fwd_itrator” will look better if it > can be changed to: “dfs_fwd_iterator”. > > It exists before this patch, but should be easy to change since there are > not many places that use it. > > > > -Mei > > > > From: Jian-Xin Lai [mailto:laij...@gmail.com] > Sent: Friday, March 04, 2011 12:42 AM > To: open64-devel > Subject: [Open64-devel] Code review for WHIRL SSA and CFG changes > > > > Hi, > > Can a gate keeper review the patch for WHIRL SSA and CFG changes? Thank you > very much. > This patch fixed the following issues: > 1. in WSSA_UPDATER::ssa_rename_tree(), BLOCK is not handled in previous > code. > > 2. in WN_CFG_VERIFY_ACTION::Finalize(), dfs_iterator is used instead of > BB_iterator because some of BB is deleted and BB_iterator will also returns > those deleted bb. > 3. in wn_cfg_template.h, the kid count of SWITCH/COMPGOTO can be 2 or 3. The > default target is valid only if the kid count is 3. > > and an enhancement: > 1. in wssa_update.h/cxx, Delete_BB is added to WSSA_UPDATER to support > delete a BB from CFG, as well as its statements from WHIRL tree. > > -- > Regards, > Lai Jian-Xin > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
