This patch looks fine to me.
2011/3/4 朱庆 <zqing1...@gmail.com>
> Hi all,
>
> Can gatekeeper help review this fix?
>
> The problem is, the function HB_Form_Hyperblocks should take a
> BB_REGION* instead of BB_REGION& as parameter, because BB_REGION&
> would lead to REGION construction when we pass NULL as this parameter,
> and this could cause failure with some STL.
>
> Index: osprey/be/cg/hb.cxx
> ===================================================================
> --- osprey/be/cg/hb.cxx (revision 3503)
> +++ osprey/be/cg/hb.cxx (working copy)
> @@ -581,7 +581,7 @@
>
> /////////////////////////////////////
> void
> -HB_Form_Hyperblocks(RID *rid, const BB_REGION& bb_region)
> +HB_Form_Hyperblocks(RID *rid, const BB_REGION* bb_region)
> /////////////////////////////////////
> // See interface description.
> /////////////////////////////////////
> Index: osprey/be/cg/hb.h
> ===================================================================
> --- osprey/be/cg/hb.h (revision 3503)
> +++ osprey/be/cg/hb.h (working copy)
> @@ -451,7 +451,7 @@
> extern HB* HB_Alloc(MEM_POOL* pool);
>
> extern void HB_Init(void);
> -extern void HB_Form_Hyperblocks(RID* rid, const BB_REGION& bb_region);
> +extern void HB_Form_Hyperblocks(RID* rid, const BB_REGION* bb_region);
> //
> // Some typedefs to make using STL lists easier
> //
>
> Thanks
> zhuqing
>
>
> ------------------------------------------------------------------------------
> What You Don't Know About Data Connectivity CAN Hurt You
> This paper provides an overview of data connectivity, details
> its effect on application quality, and explores various alternative
> solutions. http://p.sf.net/sfu/progress-d2d
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
