for the release tree, Suneel is the gatekeeper. For tot, please go ahead
sun

On Tue, Mar 29, 2011 at 2:47 AM, Shin, Jaewook <jaew...@hp.com> wrote:
> Hi Sun,
>
> Thanks for the approval on this patch. Can I check in the fix now? I know the 
> trunk was frozen for the 4.2.4 release but I am not sure if it's open again.
>
> Jaewook
>
>
> -----Original Message-----
> From: Sun Chan [mailto:sun.c...@gmail.com]
> Sent: Wednesday, March 23, 2011 5:12 AM
> To: Shin, Jaewook
> Cc: Zhao, Min; open64-devel@lists.sourceforge.net
> Subject: Re: Code Review Request (bug #721)
>
> the fix should be fine.
> Sun
>
> On Wed, Mar 23, 2011 at 8:34 AM, Shin, Jaewook <jaew...@hp.com> wrote:
>> Hi Sun,
>>
>>
>>
>> Could you review the attached patch for bug #721? This patch improves upon
>> the earlier ones in several ways; First, the generated code goes to GOT only
>> for symbols that are preemptible (exp_loadstore.cxx:L1180). Second, string
>> comparison for ".rodata" is eliminated. Third, it keeps CPIC when both PIC
>> and CPIC are given. This allows further optimizations for CPIC later.
>> Fourth, this patch covers both -m64 and -m32. Finally, this patch is tested
>> for both SPEC FP and INT and passed both to the same level as PIC. For both
>> test suites, it fails only for 416.gamess but PIC also fails for the same
>> one. Please let me know if you need further information for the patch.
>> Thanks.
>>
>>
>>
>> Jaewook
>>
>>
>

------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and publish 
your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel

Reply via email to