strange that the original code turned off simplifier first and tries to do that locally. Does anyone know why? These kind of thing is best done in the simplifier and you wouldn't need this change. On principle, we don't want to have to deal with all kinds of "canonicalization" everywhere, do we? Sun
On Fri, Apr 1, 2011 at 2:45 AM, Gilmore, Doug <doug.gilm...@amd.com> wrote: > I attached the test and patch that were already attached to the bug. > > The text in the comment associated with patch attachment is: > > The comment above the code I changed is: > > // For example, > // I4I4LDID 41 <1,4,.preg_I4> T<4,.predef_I4,4> # i > // U4INTCONST 8 (0x8) > // I4MPY > // U8I4CVT > // U8U8LDID 0 <2,1,rowsptr2> T<32,anon_ptr.,8> > // U8ADD > // This can be safely converted into (without performance loss): > // I8INTCONST 8 (0x8) > // I8I4LDID 41 <1,4,.preg_I4> T<4,.predef_I4,4> # i > // I8MPY > // U8U8LDID 0 <2,1,rowsptr2> T<32,anon_ptr.,8> > // U8ADD > // We will do this only for small powers of 2 so that > // the I8MPY gets converted into shifts (no imul64 versus imul32). > > The original code does not implement this transformation, > the supplied patch I believe does. > > Could a gatekeeper review/approve this change when he or she has a chance? > > Thanks, > > Doug > > ------------------------------------------------------------------------------ > Create and publish websites with WebMatrix > Use the most popular FREE web apps or write code yourself; > WebMatrix provides all the features you need to develop and > publish your website. http://p.sf.net/sfu/ms-webmatrix-sf > > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
