This patch looks good to me.
2011/4/7 Hui Shi <kalin....@gmail.com>
> Would a gatekeeper please review this change?
>
> In Hash_TCON, there exist an expression has no effect.
> case MTYPE_V32F4:
> case MTYPE_V32F8:
> hash += TCON_v0(*t) + TCON_v1(*t) + TCON_v2(*t) + TCON_v3(*t);
> TCON_v4(*t) + TCON_v5(*t) + TCON_v6(*t) + TCON_v7(*t);
> break;
>
> This will not cause any bug but I think the original thought is accumulate
> all integer values to make the hash value. Fix is direct add two
> expressions.
>
> Index: osprey/common/com/x8664/targ_const.cxx
> ===================================================================
> --- osprey/common/com/x8664/targ_const.cxx (revision 3537)
> +++ osprey/common/com/x8664/targ_const.cxx (working copy)
> @@ -5943,7 +5943,7 @@
> break;
> case MTYPE_V32F4:
> case MTYPE_V32F8:
> - hash += TCON_v0(*t) + TCON_v1(*t) + TCON_v2(*t) + TCON_v3(*t);
> + hash += TCON_v0(*t) + TCON_v1(*t) + TCON_v2(*t) + TCON_v3(*t) +
> TCON_v4(*t) + TCON_v5(*t) + TCON_v6(*t) + TCON_v7(*t);
> break;
> default:
>
>
>
> ------------------------------------------------------------------------------
> Xperia(TM) PLAY
> It's a major breakthrough. An authentic gaming
> smartphone on the nation's most reliable network.
> And it wants your games.
> http://p.sf.net/sfu/verizon-sfdev
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
