Hi Sun, I've made a new patch for bug 721. Can you review the attached patch?
The summary of the patch is as follows. Here, "721.patch" refers to my earlier check-in, i.e., the change for revision 3530. 1. Reverted a fix in 721.patch that removed the code where Gen_PIC_Call_Shared is set to false. Thus, Gen_PIC_Call_Shared is always set to false again, as it used to be. This fixes a new bug 762, where the compiler breaks while compiling 416.gamess. (See config_targ.cxx:819 in the attached patch.) 2. Reverted a fix in 721.patch that allowed only 'preemptible' symbols to go into GOT. This remains the same as in my recent code review request to you. So, this fixes the shared object compilation problem described in bug 721. (See exp_loadstore.cxx:1176.) 3. All my changes in 721.patch that used Gen_PIC_Call_Shared are changed to use Gen_PIE instead, a new variable that represents "-pie" option. This fixes the original problem reported in bug 721. #1 and #2 revert to where they used to be before 721.patch. These remove two new issues generated from 721.patch. #3 fixes the original issue reported in bug 721 but in a different way by creating a new global variable Gen_PIE that represents "-pie" for position independent executables. Now, all "-fpie", "-pie" and "-fPIE" are mapped to "-TENV:PIE" instead of "-TENV:PIC" and Gen_PIE becomes true when one of the three is passed. I recently realized that Gen_PIC_Call_Shared or CPIC was for dynamic executables and we needed a new variable to represent 'position independent executables'. The attached patch went through both SPEC INT and FP with and without "-fpie -pie" in revision 3522. Jaewook
721-v3.patch
Description: 721-v3.patch
------------------------------------------------------------------------------ Forrester Wave Report - Recovery time is now measured in hours and minutes not days. Key insights are discussed in the 2010 Forrester Wave Report as part of an in-depth evaluation of disaster recovery service providers. Forrester found the best-in-class provider in terms of services and vision. Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
