looks good, please go ahead
Sun
On Wed, Apr 13, 2011 at 7:13 AM, Mathew, Pallavi <pallavi.mat...@amd.com> wrote:
> Here is the updated patch for review:
>
> Index: osprey/be/lno/sclrze.cxx
> ===================================================================
> --- osprey/be/lno/sclrze.cxx (revision 3542)
> +++ osprey/be/lno/sclrze.cxx (working copy)
> @@ -197,7 +197,12 @@
> WN *load_wn = dep_graph->Get_Wn(sink);
> OPCODE opcode = WN_opcode(load_wn);
> if (OPCODE_is_load(opcode)) {
> - if (OPCODE_operator(opcode) != OPR_LDID) {
> + if (OPCODE_operator(opcode) != OPR_LDID &&
> + // Do not scalarize MTYPE_M loads as this may result in a parent
> MTYPE_M store
> + // having a child that is not MTYPE_M and function 'Add_def' may
> not be to handle
> + // such stores during coderep creation. The check here catches a
> 'use' involving
> + // MTYPE_M whereas the check at the beginning of 'Process_Store'
> catches 'defs'.
> + (WN_rtype(load_wn) != MTYPE_M) && (WN_desc(load_wn) != MTYPE_M)) {
> ACCESS_ARRAY *load = (ACCESS_ARRAY *)
> WN_MAP_Get(LNO_Info_Map,WN_kid0(load_wn));
> if (WN_operator(WN_kid0(load_wn)) == OPR_ARRAY &&
>
> Thanks.
> Pallavi
>
> -----Original Message-----
> From: Sun Chan [mailto:sun.c...@gmail.com]
> Sent: Tuesday, April 12, 2011 3:21 PM
> To: Mathew, Pallavi
> Cc: open64-devel@lists.sourceforge.net
> Subject: Re: [Open64-devel] Code review request for bug# 763
>
> please add some comments to the fix. I don't believe in comments made
> to bug databases. Case in point, since SGI's release, the code base
> has gone through multiple source control and bug structures, most of
> them lost to the developers, including the original SGI bug database.
> Sun
>
> On Wed, Apr 13, 2011 at 1:50 AM, Mathew, Pallavi <pallavi.mat...@amd.com>
> wrote:
>> Hi,
>>
>>
>>
>> The attached patch is a proposed fix for bug# 763. The failing example and
>> description of the problem and fix are attached here and also to the bug
>> report.
>>
>> Can a gatekeeper please review the fix?
>>
>>
>>
>> Thanks.
>>
>> -Pallavi
>>
>> ------------------------------------------------------------------------------
>> Forrester Wave Report - Recovery time is now measured in hours and minutes
>> not days. Key insights are discussed in the 2010 Forrester Wave Report as
>> part of an in-depth evaluation of disaster recovery service providers.
>> Forrester found the best-in-class provider in terms of services and vision.
>> Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
>> _______________________________________________
>> Open64-devel mailing list
>> Open64-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/open64-devel
>>
>>
>
>
>
------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
