Hi Sun,

Attached is a new patch for bug 721. This new patch reverts all changes in my 
earlier patch for revision 3530. Instead, the new patch makes the following 
modification.

Index: osprey/common/com/config.cxx
===================================================================
--- osprey/common/com/config.cxx       (revision 3546)
+++ osprey/common/com/config.cxx    (working copy)
@@ -1453,8 +1453,15 @@
   if ( Use_Large_GOT )   Guaranteed_Small_GOT = FALSE;
-  /* if we get both TENV:CPIC and TENV:PIC, use only TENV:CPIC */
-  if (Gen_PIC_Call_Shared && Gen_PIC_Shared) Gen_PIC_Shared = FALSE;
+  /* If we get both TENV:CPIC and TENV:PIC, use only TENV:PIC.
+   *
+   * To fix bug 721, "use only TENV:CPIC" is changed to "use only TENV:PIC".
+   * While PIC, represented by Gen_PIC_Shared, is for 'shared objects',
+   * CPIC, represented by Gen_PIC_Call_Shared, is for 'dynamic executables'
+   * that call functions in shared objects. Since CPIC should be the default,
+   * Gen_PIC_Call_Shared is not very useful.
+   */
+  if (Gen_PIC_Call_Shared && Gen_PIC_Shared) Gen_PIC_Call_Shared = FALSE;
   /* Select optimization options: */

The uses of Gen_PIC_Call_Shared seem pretty benign. Mostly, they use 
Gen_PIC_Call_Shared together with Gen_PIC_Shared so that either one is 
effective. There are a few cases where Gen_PIC_Call_Shared is used alone but 
not using Gen_PIC_Call_Shared is not harmful. Gen_PIC_Call_Shared used to be 
false and remains false before and after this fix.

This fix passes both SPEC INT and FP benchmarks in the current revision without 
any additional flags, and it passes both SPEC INT and FP with "-fpie -pie" in 
revision 3522 except for 416.gamess. It also passes the reported cases in bug 
721 and 762.

Jaewook

Attachment: 721-v4.patch
Description: 721-v4.patch

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel

Reply via email to