Can a gatekeeper review the following change?
This change affects the existing "array remapping" optimization.
The following change adds a restriction to exclude arrays with
non-zero field_id (e.g., arrays that are themselves members of
structs) from being considered as array remapping candidates.
The current algorithm does not handle these arrays anyway, and
before this change, these arrays would be rejected downstream
in the legality phase. After this change, the legality checking
should be able to proceed more smoothly.
Index: osprey/ipa/main/optimize/ipo_struct_opt.cxx
===================================================================
--- osprey/ipa/main/optimize/ipo_struct_opt.cxx (revision 3546)
+++ osprey/ipa/main/optimize/ipo_struct_opt.cxx (working copy)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009-2010 Advanced Micro Devices, Inc. All Rights Reserved.
+ * Copyright (C) 2009-2011 Advanced Micro Devices, Inc. All Rights Reserved.
*/
////////////////////////////////////////////////////////////////////////////
@@ -1669,6 +1669,10 @@
TY_mtype(TY_etype(TY_pointed(WN_ty(array_base_wn)))) !=
array_remapping_candidate_mtype)
return FALSE; // array of another type
+ if (WN_operator(array_base_wn) == OPR_LDA &&
+ WN_field_id(array_base_wn) != 0)
+ return FALSE; // base array just a little too complicated: e.g. it is a
+ // member of a struct, etc.
}
return TRUE;
}
Thanks,
Michael Lai
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
