I already read through the code. Your comments are on top of what I
reviewed already. E.g. the splitting (cleanup) of gcm is due to my
input
Sun
On Wed, Apr 27, 2011 at 5:12 PM, Jian-Xin Lai <laij...@gmail.com> wrote:
> This patch looks fine to me. But since it's in the common code and may
> affect all targets, could a global keeper review and approve this patch?
> Thanks.
>
> 2011/4/26 Hui Shi <kalin....@gmail.com>
>>
>> Would gatekeeper help review this patch?
>>
>> The priorty of bitwise operator is lower than relational operaotr.
>> So following code has potential problem.
>>
>> In Check_TCON ( TCON *tc )
>> Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
>> ("High order word of %s TCON non zero %x",
>> Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
>> The original meaning is checking if TCON_V1, TCON_V2, TCON_V3 all zero,
>> now the assertion will not happen when TCON_V2 is non-zeron.
>>
>> in control.cxx
>> #define CGI_IS_INT_TYPE 0x0001
>> #define CGI_is_int_type(c) ((c)->flags & CGI_IS_INT_TYPE != 0)
>> When CGI_IS_INT_TYPE changes the marco value, the second marco will not
>> correct.
>>
>> Regards
>> Shi Hui
>>
>>
>> ------------------------------------------------------------------------------
>> WhatsUp Gold - Download Free Network Management Software
>> The most intuitive, comprehensive, and cost-effective network
>> management toolset available today. Delivers lowest initial
>> acquisition cost and overall TCO of any competing solution.
>> http://p.sf.net/sfu/whatsupgold-sd
>> _______________________________________________
>> Open64-devel mailing list
>> Open64-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/open64-devel
>>
>
>
>
> --
> Regards,
> Lai Jian-Xin
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today. Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
