Author: shihui
Date: 2011-04-27 22:20:14 -0400 (Wed, 27 Apr 2011)
New Revision: 3574
Modified:
trunk/osprey/common/com/MIPS/targ_const.cxx
trunk/osprey/common/com/NVISA/targ_const.cxx
trunk/osprey/common/com/SL/targ_const.cxx
trunk/osprey/common/com/controls.cxx
trunk/osprey/common/com/ia64/targ_const.cxx
trunk/osprey/common/com/loongson/targ_const.cxx
trunk/osprey/common/com/ppc32/targ_const.cxx
trunk/osprey/common/com/x8664/targ_const.cxx
Log:
Fixing incorrect expression assuming wrong operoator priority.
The priorty of bitwise operator is lower than relational operator.
Code review by Jianxin and Sun Chan
Modified: trunk/osprey/common/com/MIPS/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/MIPS/targ_const.cxx 2011-04-26 05:21:38 UTC (rev
3573)
+++ trunk/osprey/common/com/MIPS/targ_const.cxx 2011-04-28 02:20:14 UTC (rev
3574)
@@ -229,14 +229,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/NVISA/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/NVISA/targ_const.cxx 2011-04-26 05:21:38 UTC
(rev 3573)
+++ trunk/osprey/common/com/NVISA/targ_const.cxx 2011-04-28 02:20:14 UTC
(rev 3574)
@@ -243,14 +243,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/SL/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/SL/targ_const.cxx 2011-04-26 05:21:38 UTC (rev
3573)
+++ trunk/osprey/common/com/SL/targ_const.cxx 2011-04-28 02:20:14 UTC (rev
3574)
@@ -206,14 +206,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/controls.cxx
===================================================================
--- trunk/osprey/common/com/controls.cxx 2011-04-26 05:21:38 UTC (rev
3573)
+++ trunk/osprey/common/com/controls.cxx 2011-04-28 02:20:14 UTC (rev
3574)
@@ -345,7 +345,7 @@
} CONTROL_GROUP_INFO;
#define CGI_IS_INT_TYPE 0x0001
-#define CGI_is_int_type(c) ((c)->flags & CGI_IS_INT_TYPE != 0)
+#define CGI_is_int_type(c) ((((c)->flags) & CGI_IS_INT_TYPE) != 0)
static O_GR_EXP o_group_expansion[] = {
/*0*/ { "no-opt",
Modified: trunk/osprey/common/com/ia64/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/ia64/targ_const.cxx 2011-04-26 05:21:38 UTC (rev
3573)
+++ trunk/osprey/common/com/ia64/targ_const.cxx 2011-04-28 02:20:14 UTC (rev
3574)
@@ -227,14 +227,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/loongson/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/loongson/targ_const.cxx 2011-04-26 05:21:38 UTC
(rev 3573)
+++ trunk/osprey/common/com/loongson/targ_const.cxx 2011-04-28 02:20:14 UTC
(rev 3574)
@@ -235,14 +235,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/ppc32/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/ppc32/targ_const.cxx 2011-04-26 05:21:38 UTC
(rev 3573)
+++ trunk/osprey/common/com/ppc32/targ_const.cxx 2011-04-28 02:20:14 UTC
(rev 3574)
@@ -228,14 +228,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
Modified: trunk/osprey/common/com/x8664/targ_const.cxx
===================================================================
--- trunk/osprey/common/com/x8664/targ_const.cxx 2011-04-26 05:21:38 UTC
(rev 3573)
+++ trunk/osprey/common/com/x8664/targ_const.cxx 2011-04-28 02:20:14 UTC
(rev 3574)
@@ -254,14 +254,14 @@
case MTYPE_U2:
case MTYPE_U4:
case MTYPE_F4:
- Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
case MTYPE_I8:
case MTYPE_U8:
case MTYPE_F8:
- Is_True ( TCON_v2(*tc)|TCON_v3(*tc) == 0,
+ Is_True ( (TCON_v2(*tc)|TCON_v3(*tc)) == 0,
("High order word of %s TCON non zero %x",
Mtype_Name(TCON_ty(*tc)), TCON_v1(*tc)) );
break;
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
