It looks good to me.
Thanks,
Min
On Fri, Apr 29, 2011 at 12:14 AM, Hui Shi <kalin....@gmail.com> wrote:
> Would gatekeeper help review this patch?
>
> https://bugs.open64.net/show_bug.cgi?id=765
> Nystrom alias issue: sig fualt in ConstraintGraph::handleMemcopy
>
> Test case is memcpy without arguments generated in application
> configuration phase.
> ConstraintGraph::handleMemcopy didn't handle this case.
>
> Fix is when memcpy arguments incomplete, return early, doesn't mark the
> actual parameter modeled.
>
>
> Index: osprey/be/com/constraint_graph.cxx
> ===================================================================
> --- osprey/be/com/constraint_graph.cxx (revision 3575)
> +++ osprey/be/com/constraint_graph.cxx (working copy)
> @@ -2128,6 +2128,11 @@
>
> ConstraintGraphNode *p1Node = cgNode(firstParmId);
> ConstraintGraphNode *p2Node = cgNode(secondParmId);
> + // this can happen when configure generate a file
> + // with dummy memcpy, memmove call
> + if (p1Node == NULL || p2Node == NULL) {
> + return;
> + }
> ConstraintGraphNode *tmp = genTempCGNode();
>
> // Now, we model the semantics by inserting a read edge from
>
>
>
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today. Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
