This patch looks good for me.

2011/5/6 Hui Shi <kalin....@gmail.com>

> Would gatekeeper help review this patch?
>
> https://bugs.open64.net/show_bug.cgi?id=769
> Nystrom alias issue: OMPM2001 assert "the child mp pu pool is not equal to
> _memPool"
>
> This assert happens because,
> in AliasAnalyzer::~AliasAnalyzer, assume lower_mp will always copy parent
> PU's aliasTagMap to child in Transfer_Maps.
> This is correct for APO because lower_mp happens after LNO, then alias
> analyzer is already there.
>
> for openmp testcase, lower_mp is invoked before LNO and preopt in
> Backend_Processing,
> so the child PU doesn't have aliasTagmap copied from parent PU.
> previous fix for APO is not good, it copies extra map and delete directly.
>
>
> Now the fix is always not copy alias tag map when lower_mp create parallel
> PU.
> 1. In lower_mp, Create_MicroTask, mark don't copy alias tag map if
> aliasanalyzer exist.
> 2. In AliasAnalyzer::~AliasAnalyzer, remove code for deleteing child PU's
> aliastagmap.
>
> Regards
> Shi Hui
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today.  Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>


-- 
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel

Reply via email to