Hi David,
In general, this patch looks fine to me.
I found some format and indent issues:
* osprey/be/cg/cflow.cxx
There are some indent issues. Space should be used for indent instead of
tabstop.
* osprey/be/vho/vho_lower.cxx
The left bracket should not be on a new line. There are some indent issues.
* osprey/common/com/config.cxx
The left bracket should not be on a new line.
* osprey/common/com/symtab_defs.h:
It's better to remove the blank line before the new line and make the new
line aligned with the old lines.
2011/5/11 David Coakley <dcoak...@gmail.com>
> Could a gatekeeper please review the attached patch for a
> target-independent optimization for C++ programs?
>
> Most of the changes are again in the CG. The files modified are:
>
> osprey/be/cg/cflow.cxx
> osprey/be/cg/eh_region.cxx
> osprey/be/vho/vho_lower.cxx
> osprey/common/com/config.cxx
> osprey/common/com/config_opt.cxx
> osprey/common/com/symtab_access.h
> osprey/common/com/symtab_defs.h
> osprey/common/com/config.h
>
> Here is the proposed log message:
>
> Enable CFLOW optimization within some EH regions.
>
> Allow CG control flow optimization to reorder BB's inside of EH regions
> by updating EH region information for each BB when performing
> transformations. Previously, CFLOW would simply skip all BB's of any
> EH region in Optimize_Cyclic_Chain.
>
> To make room for CFLOW optimization, in VHO simple EH regions are merged
> into larger simple EH regions. Here, a simple EH region is an EH region
> with no real catch blocks or cleanup.
>
>
> Thanks,
>
> -David Coakley / AMD Open Source Compiler Engineering
>
>
> ------------------------------------------------------------------------------
> Achieve unprecedented app performance and reliability
> What every C/C++ and Fortran developer should know.
> Learn how Intel has extended the reach of its next-generation tools
> to help boost performance applications - inlcuding clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery,
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now.
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
