Looks fine to me. -----Original Message----- From: David Coakley [mailto:dcoak...@gmail.com] Sent: Thursday, June 09, 2011 3:49 PM To: open64-devel Subject: Re: [Open64-devel] patch to allow disabling IPA compilation support
I am still looking for a reviewer for this patch. Mike or Jian-Xin, could one of you take a look? Thanks. On Thu, May 26, 2011 at 5:16 PM, David Coakley <dcoak...@gmail.com> wrote: > Could a gatekeeper please review the attached patch to the driver and > the build system? > > Motivation: some of the more difficult portability problems in Open64 > are in the IPA support (see below). While we work on improving > portability, this patch lets us make progress on other areas without > getting blocked by IPA. This mode is not intended to be a recommended > way of building the compiler, only a short-term vehicle to make > progress faster. Here is the proposed commit message: > > Add experimental configure option to disable IPA support. > > This option is useful for leaving out some of the less portable parts > of the compiler build. Known portability problems specific to the IPA > support include: > > o ELF objects are used as the container for the intermediate WHIRL. > > o ipa_link uses dlopen and dlsym to directly call functions in ipa.so. > > o IPA compilation assumes the presence of a POSIX make and shell. > > > Changes in this patch: > > o Define make variable BUILD_SKIP_IPA when configured with --disable-ipa. > In the top-level build, skip components that are specific to IPA when > the variable is set to YES. > > o In the driver, print a friendly error message if IPA compilation is > attempted and BUILD_SKIP_IPA is defined. Also leave out code related to > IPA ELF objects (previously skipped when TARG_NVISA was defined). > > > Note: the build system has not been updated for NVISA target support. > If it ever is, it should be obvious that IPA will need to be skipped > by setting the configure variable. I hope we all agree that checking > for the feature support in the code is preferable to checking the > target architecture. Thanks, > > -David Coakley / AMD Open Source Compiler Engineering > ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
