this change is hugh. I wonder why not have a separate file to
implement your hugh functions.
Also, you have a bunch of check for WN's that doesn't really belong in lno.
e.g. is_wn_multiple_of_size, is_wn_const, is_wn_constant_val, ...
I don't have source with me, I suggest you check if similar routine
already exists and if not, add that where it is appropriate.
Also, you could have return a pointer to SAC instead of passing &SAC
and have the function return void.
Where is the class structure? Instead, you are writing C. And very
large function body at that.
Sun
On Tue, Jul 19, 2011 at 6:23 AM, David Coakley <dcoak...@gmail.com> wrote:
> This patch implements a "copy-in/copy-out" optimization for a member
> of a structure whose accesses exhibit poor cache locality. The idea is
> to identify a section of code where this optimization is beneficial and
> replace the occurrences of this structure member by a local variable.
> Care is taken to save ("copy-in") and restore ("copy-out") the
> correct value of the structure member immediately before and after the
> code section.
>
> For example, in the following section of code:
>
> loop
> loop
> ... struct.member ...
> loopend
> loopend
>
> if it can be determined that the accesses to "struct.member" will result
> in a lot of cache misses, the compiler may transform the above to:
>
> t = struct.member ("copy-in") (if necessary)
> loop
> loop
> ... t ...
> loopend
> loopend
> struct.member = t ("copy-out") (if necessary)
>
>
> I have attached a design document that describes details of the
> implementation.
>
> The bulk of the patch is new code added to lno/array_copy.cxx; there
> are a few small changes in IPA-related files and one modification in
> wgen.
>
> Could one or more gatekeepers please review the patch? Thanks,
>
> -David Coakley / AMD Open Source Compiler Engineering
>
> ------------------------------------------------------------------------------
> Storage Efficiency Calculator
> This modeling tool is based on patent-pending intellectual property that
> has been used successfully in hundreds of IBM storage optimization engage-
> ments, worldwide. Store less, Store more with what you own, Move data to
> the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
> _______________________________________________
> Open64-devel mailing list
> Open64-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>
>
------------------------------------------------------------------------------
Storage Efficiency Calculator
This modeling tool is based on patent-pending intellectual property that
has been used successfully in hundreds of IBM storage optimization engage-
ments, worldwide. Store less, Store more with what you own, Move data to
the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
