The changes look fine to me. There is the separate issue that Sun raises of whether to move toward non-shared builds. I think there are some platforms where it simplifies things if we can build non-shared, so I think it is worth having as an option.
-----Original Message----- From: David Coakley [mailto:dcoak...@gmail.com] Sent: Thursday, July 28, 2011 4:34 PM To: open64-devel Cc: Mike Murphy Subject: Code review request for changes to support non-shared build [BUILD] The attached patch adds support for an experimental '--disable-shared' configuration option. This option is useful for avoiding the portability problems introduced by the way Open64 uses shared objects. For example, the use of static initializers to bind pointers to functions (the "weak symbol workaround") in the loading process does not work in Cygwin/Windows environments. In the non-shared build, the executables be, inline, whirl2c, and whirl2f are standalone and do not load any shared objects other than the standard system libraries. Long term, I think building the compiler executables without shared objects might be the way to go for all platforms. The resulting executables are easier to debug and the driver is simplified -- no LD_LIBRARY_PATH. And lots of ugly "weak symbol workaround" code could be deleted. But first ipa_link will need some changes in order to work for the non-shared configuration; in this patch, the --disable-shared option implies --disable-ipa. Mike, your review would be appreciated since NVIDIA seems to have encountered these same issues when porting some Open64 components to Windows. The details of the changes are in the attached msg.txt file. Thanks, -David Coakley / AMD Open Source Compiler Engineering ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
