Sorry about the flub. This fix looks good to me.
Thanks! Doug > -----Original Message----- > From: 朱庆 [mailto:zqing1...@gmail.com] > Sent: Tuesday, October 11, 2011 12:40 AM > To: open64-devel@lists.sourceforge.net > Subject: [Open64-devel] Code review request for bug880, build fail > caused by bug771 [WOPT] > > Hi all, > > Could a gatekeeper review the attached patch for bug #880? > > This is caused by new rev3753, in follwoing code "TCON_R10" is only > defined at x8664, so this will break other targets build. > > Modified: trunk/osprey/be/opt/opt_vn_expr.cxx > =================================================================== > --- trunk/osprey/be/opt/opt_vn_expr.cxx 2011-10-08 13:26:04 UTC (rev > 3752) > +++ trunk/osprey/be/opt/opt_vn_expr.cxx 2011-10-09 05:17:57 UTC (rev > +++ 3753) > @@ -651,6 +651,9 @@ > else if (this_mty == MTYPE_F4 && > TCON_R4(other_tcon) == 0 && TCON_R4(_tcon) == 0) > truth = TCON_word0(other_tcon) == TCON_word0(_tcon); > + else if (this_mty == MTYPE_F10 && > + TCON_R10(other_tcon) == 0 && TCON_R10(_tcon) == 0) > + truth = TCON_v2(other_tcon) == TCON_v2(_tcon); > #endif > else { > BOOL folded; > > The fix is to make a new fun "Targ_Is_Neg_Zero" for each target to > determine whether the const is -0.0, just like "Targ_Is_Zero". > > Thanks > zhuqing ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
