For now, may be backout the fix until the regression is resolved? Sun On 10/18/11, Rao, Shivarama <shivarama....@amd.com> wrote: > Hi Zhuqing, > > Thanks for the small testcase. I am looking into this. > > Regards, > Shivaram > > > -----Original Message----- > From: 朱庆 [mailto:zqing1...@gmail.com] > Sent: Tuesday, October 18, 2011 4:27 PM > To: Sun Chan > Cc: open64-devel@lists.sourceforge.net > Subject: Re: [Open64-devel] r3764 - trunk/osprey/be/opt > > Double checked on this, I can confirm it is r3764 that caused the failure. > there is another small case also fail with the same err. see bug882. > > zhuqing > 2011/10/18 Sun Chan <sun.c...@gmail.com>: >> you meant 2 checkins that showed diff between the stmt got dce'd or not? >> Sun >> >> On Tue, Oct 18, 2011 at 4:35 PM, 朱庆 <zqing1...@gmail.com> wrote: >>> >>> I'll double check on this, there is only one checkin between two days >>> result. >>> >>> zhuqing >>> 2011/10/18 Sun Chan <sun.c...@gmail.com>: >>> > This is strange. Must be a regression from elsewhere. I am sure the >>> > identity >>> > stmt had been removable without your change before. Is this fix the >>> > right >>> > fix? >>> > Fred, your comment? >>> > Sun >>> > >>> > On Sun, Oct 16, 2011 at 6:12 PM, <s...@open64.net> wrote: >>> >> >>> >> Author: shivaram >>> >> Date: 2011-10-16 06:12:14 -0400 (Sun, 16 Oct 2011) >>> >> New Revision: 3764 >>> >> >>> >> Modified: >>> >> trunk/osprey/be/opt/opt_dce.cxx >>> >> Log: >>> >> Fix for bug#787. Removal of identity assignment statements(i=i) is >>> >> prevented if lhs is not propagatable. >>> >> CR by Ye,Mei and Gautam >>> >> >>> >> >>> >> >>> >> Modified: trunk/osprey/be/opt/opt_dce.cxx >>> >> =================================================================== >>> >> --- trunk/osprey/be/opt/opt_dce.cxx 2011-10-14 08:12:52 UTC (rev >>> >> 3763) >>> >> +++ trunk/osprey/be/opt/opt_dce.cxx 2011-10-16 10:12:14 UTC (rev >>> >> 3764) >>> >> @@ -2149,7 +2149,8 @@ >>> >> >>> >> if (OPERATOR_is_scalar_store (opr) && >>> >> Enable_identity_removal() && >>> >> - stmt->Is_identity_assignment_removable()) // if COPYPROP >>> >> assumes >>> >> the stmt is deleted >>> >> + stmt->Is_identity_assignment_removable() && >>> >> + !(stmt->Lhs()->Flags() & CF_DONT_PROP)) // if COPYPROP >>> >> assumes >>> >> the >>> >> stmt is deleted >>> >> return FALSE; >>> >> >>> >> // statements with zero-version chi nodes are required >>> >> @@ -3262,7 +3263,8 @@ >>> >> >>> >> if (OPERATOR_is_scalar_store (opr) && >>> >> Enable_identity_removal() && >>> >> - stmt->Is_identity_assignment_removable()) { >>> >> + stmt->Is_identity_assignment_removable() && >>> >> + !(stmt->Lhs()->Flags() & CF_DONT_PROP)) { >>> >> // process the rhs expression, if any >>> >> CODEREP *rhs = stmt->Rhs(); >>> >> if ( rhs != NULL ) { >>> >> >>> >> >>> >> >>> >> >>> >> ------------------------------------------------------------------------------ >>> >> All the data continuously generated in your IT infrastructure >>> >> contains >>> >> a >>> >> definitive record of customers, application performance, security >>> >> threats, fraudulent activity and more. Splunk takes this data and >>> >> makes >>> >> sense of it. Business sense. IT sense. Common sense. >>> >> http://p.sf.net/sfu/splunk-d2d-oct >>> >> _______________________________________________ >>> >> Open64-devel mailing list >>> >> Open64-devel@lists.sourceforge.net >>> >> https://lists.sourceforge.net/lists/listinfo/open64-devel >>> > >>> > >>> > >>> > ------------------------------------------------------------------------------ >>> > All the data continuously generated in your IT infrastructure contains >>> > a >>> > definitive record of customers, application performance, security >>> > threats, fraudulent activity and more. Splunk takes this data and >>> > makes >>> > sense of it. Business sense. IT sense. Common sense. >>> > http://p.sf.net/sfu/splunk-d2d-oct >>> > _______________________________________________ >>> > Open64-devel mailing list >>> > Open64-devel@lists.sourceforge.net >>> > https://lists.sourceforge.net/lists/listinfo/open64-devel >>> > >>> > >> >> > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2d-oct > _______________________________________________ > Open64-devel mailing list > Open64-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/open64-devel >
------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
