Great, here is an updated version of the patch. Note that only MIPS, ia64, and loongson have a zero register, while NVISA, SL, x8664, and ppc32 do not.
Could a gatekeeper review this change when they have the chance? Thanks, Doug From: Sun Chan [mailto:[email protected]] Sent: Monday, November 21, 2011 2:51 PM To: Gilmore, Doug Cc: [email protected] Subject: Re: [Open64-devel] FW: CG minor cleanup review request sure Sun On Tue, Nov 22, 2011 at 5:56 AM, Gilmore, Doug <[email protected]<mailto:[email protected]>> wrote: Sorry for the delay in getting back, Jianxin had a different proposal: we can define a new function CGTARG_Is_Shift_Redundant() and implement it for all targets. Sun: how does that sound? Doug From: Gilmore, Doug [mailto:[email protected]<mailto:[email protected]>] Sent: Wednesday, November 09, 2011 2:59 PM To: Sun Chan Cc: [email protected]<mailto:[email protected]> Subject: Re: [Open64-devel] FW: CG minor cleanup review request From: Sun Chan [mailto:[email protected]<mailto:[email protected]>] Sent: Wednesday, November 09, 2011 2:41 PM To: Gilmore, Doug Cc: [email protected]<mailto:[email protected]> Subject: Re: [Open64-devel] FW: CG minor cleanup review request Or let CGTARG_Is_Right_Shift_Op() return false for X86 at where it is defined [Doug: ] Sounds good with me, and I'll add a comment about that the use of the function is only relevant on machines with assumed zero registers. Any objections to Sun's proposal. Doug On Thu, Nov 10, 2011 at 4:34 AM, Gilmore, Doug <[email protected]<mailto:[email protected]>> wrote: I see that another Post-5.0 change has been committed to the trunk. Could someone review this change when they have a chance. Thanks, Doug From: Gilmore, Doug Sent: Wednesday, October 19, 2011 11:57 PM To: Jian-Xin Lai Cc: [email protected]<mailto:[email protected]> Subject: RE: [Open64-devel] CG minor cleanup review request s/got it/got in/ Sorry about that. Doug From: Gilmore, Doug [mailto:[email protected]<mailto:[email protected]>] Sent: Wednesday, October 19, 2011 11:33 PM To: Jian-Xin Lai Cc: [email protected]<mailto:[email protected]> Subject: Re: [Open64-devel] CG minor cleanup review request I wasn't too concerned about when it got it. I just wanted to know what people thought was a better stylistic solution to this problem in the long term. Doug From: Jian-Xin Lai [mailto:[email protected]<mailto:[email protected]>] Sent: Wednesday, October 19, 2011 11:13 PM To: Gilmore, Doug Cc: [email protected]<mailto:[email protected]> Subject: Re: [Open64-devel] CG minor cleanup review request Hi Doug, Do you plan to add this patch to the coming 5.0 release? 2011/10/19 Gilmore, Doug <[email protected]<mailto:[email protected]>> I noticed tons of warnings associated with CGTARG_Is_Right_Shift_Op() when I compiled a source file in CG with "-Wall -O2". The patch cleans up the warnings. Note that the only use for CGTARG_Is_Right_Shift_Op() is the following code in cgemit.cxx: if (CGTARG_Is_Right_Shift_Op (op)) { if (TN_register(OP_opnd(op,0+predicated)) == REGISTER_zero) { DevWarn ("Redundant shift instruction in %sBB:%d (PC=0x%x)", BB_rotating_kernel(OP_bb(op)) ? "SWPd " : "", BB_id(OP_bb(op)), PC); if (TFile != stdout) { /* only print to .t file */ Print_OP_No_SrcLine (op); } } Since there are no zero registers the X8664 architectures, it didn't matter that CGTARG_Is_Right_Shift_Op() produced bogus results. Another approach would be just removing the function from osprey/be/cg/x8664/cgtarget_arch.h and replacing the above code snippet with: #if defined(TARG_MIPS) || defined(TARG_IA64) || defined(TARG_LOONGSON) <SNIPPET> #endif I think either approach is fine, I'll let the reviewers decide which (or yet another) approach we should use. Could a gatekeeper take a look at the patch when they have the chance? Thanks, Doug ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Open64-devel mailing list [email protected]<mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/open64-devel -- Regards, Lai Jian-Xin ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Open64-devel mailing list [email protected]<mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/open64-devel
cgtarget_arch_v2.patch
Description: cgtarget_arch_v2.patch
------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d
_______________________________________________ Open64-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/open64-devel
