> -----Original Message----- > From: Sun Chan [mailto:sun.c...@gmail.com] > Sent: Saturday, March 17, 2012 2:56 PM > To: Gilmore, Doug > Cc: open64-devel > Subject: Re: [Open64-devel] Fix to bug 917 > > The BE uses the same const fold in simplifier. > to include simplifier in fortran FE. My question is, are you using > that? Or writing your own? I am using the existing implementation of constant folding in the FFE, which is already used for other folding other constant expressions. > If you are writing your own, I just want to > point out the potential problems in terms of rounding/... IEEE issue Note when folding the Real intrinsic, it is just treated as a conversion operation (note the use of Cvrt_Opr in the patch), for which there is an existing implementation in the constant folder in the FFE.
Thus if there were issues with rounding they would have been exposed long time ago. Doug > Sun > > On Sun, Mar 18, 2012 at 4:08 AM, Gilmore, Doug <doug.gilm...@amd.com> > wrote: > >> -----Original Message----- > >> From: Sun Chan [mailto:sun.c...@gmail.com] > >> Sent: Saturday, March 17, 2012 10:37 AM > >> To: Gilmore, Doug > >> Cc: open64-devel > >> Subject: Re: [Open64-devel] Fix to bug 917 > >> > >> which part of const_fold functions do you intend to use? Or are you > >> writing your own? > > I am using the same mechanism as the other folding operations do. > Folding > > is done in a routine written in Fortran. > >> Note also that you will need to observe IEEE > >> settings for floats > >> Sun > > Given that we use the same execution mechanism that used for the > > folding of other operations. If it is being done incorrectly in this > > patch, it be incorrect for all folding operations. > > > > Have we seen other constant foldings incorrectly folded? > > > > Doug > >> > >> On Fri, Mar 16, 2012 at 3:55 AM, Gilmore, Doug > <doug.gilm...@amd.com> > >> wrote: > >> > Other Fortran front ends are capable of folding calls to > intrinsics > >> that > >> > have constant arguments in parameter statements, but this > >> functionality > >> > is missing in the Open64 front end. > >> > > >> > As a first cut, I went to the process of handling this for the > real > >> > intrinsic. The patch and test case is attached. > >> > > >> > We will be adding more of this functionality for other intrinsics > >> > in the near future. > >> > > >> > Can a gatekeeper review this change for me? > >> > > >> > Thanks, > >> > > >> > Doug > >> > > >> > ------------------------------------------------------------------ > --- > >> --------- > >> > This SF email is sponsosred by: > >> > Try Windows Azure free for 90 days Click Here > >> > http://p.sf.net/sfu/sfd2d-msazure > >> > _______________________________________________ > >> > Open64-devel mailing list > >> > Open64-devel@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/open64-devel > >> > > > > > ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
