I am glad you are adopting the configure-based build system for ppc.
Here are my review comments:
1) In Makefile.in, there is no need to duplicate the "install" rule.
It looks like the "install_compiler" rule could be shared by rewriting
it as:
install_compiler:
export TOOLROOT=@prefix@; \
export TOP_SRCDIR=$(TOP_SRCDIR); \
$(TOP_SRCDIR)/install_compiler.sh $(MACHINE_TYPE) $(if
$(BUILD_FORTRAN),"YES","NO") @CROSS_TARGET@
Just curious, why does the ppc install skip libgcc and libstdc++-v3?
2) In osprey-gcc-4.2.0/gcc/Makefile.in, my suggestion is to delete
unused code rather than commenting it out.
3) In osprey-gcc-4.2.0/gcc/Makefile.in, most of the large rule
"install-common" is duplicated to add the EXTRA_PARTS handling. Do
you know of a problem with using EXTRA_PARTS for all targets? I think
it is fine for x86.
-David Coakley / AMD Open Source Compiler Engineering
2012/4/7 Huan Luo <luo_huan...@126.com>:
> Hi,
> This is a patch to trunk-r3898 which helps open64 x86-ppc cross compiler
> generates its own gcc preprocessor instead using gcc of the native system.
> Also it changes the way in which the cross compiler is installed.
> The test result on a x86 machine is available.
> Would you please help review this patch? Thanks very much.
>
> --
> Best wishes.
>
> Huan Luo
>
>
>
------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
