Hi Jian,

  I have filed bug #978 for this patch.

Regards,
Shivaram

From: Jian-Xin Lai [mailto:laij...@gmail.com]
Sent: Friday, June 01, 2012 8:46 AM
To: Sun Chan
Cc: Rao, Shivarama; open64-devel
Subject: Re: [Open64-devel] Code review request for bug#978 (CG)

Hi Shivarama,

Could you please also file a bug (if there isn't one) and attach the test case 
to the bugzilla before you check in this patch? So that you can refer the bug 
number when you submit the patch. Thank you very much.
2012/5/31 Sun Chan <sun.c...@gmail.com<mailto:sun.c...@gmail.com>>
looks good to me
Sun
On Thu, May 31, 2012 at 8:05 PM, Rao, Shivarama 
<shivarama....@amd.com<mailto:shivarama....@amd.com>> wrote:
Hi,

  Could a gatekeeper please review the following changes, which would fix cmake 
build under Open64?

   The hyperblock scheduler makes the following transformation, which is 
incorrect in 64 bit mode.
    From:
        addl $1,%edx
        movsbl 0(%rdx,%r9,1), %eax

     To:
         movsbl 1(%rdx,%r9,1), %eax
         addl $1,%edx

In the  test environment $edx value is initially -1 and the address computed 
for movsbl would have been 0+0+r9*1. With the above optimization, the address 
computed is 1+0xffff+$r9*1 which is incorrect. The fix disallows the above 
transformation in 64 bit mode when add is a 32 bit instruction.

Regards,
Shivaram



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net<mailto:Open64-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/open64-devel


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net<mailto:Open64-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/open64-devel



--
Regards,
Lai Jian-Xin
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel

Reply via email to