pls go ahead
Sun
On Fri, Jul 13, 2012 at 2:47 PM, zhangliwei <lifelong830...@gmail.com> wrote:
> Hi,
>
> Could a gatekeeper please help review this code? It’s some syntax
> error.
>
> The patch:
>
> Index: osprey/be/cg/sched/sched_heur.cxx
>
> ===================================================================
>
> --- osprey/be/cg/sched/sched_heur.cxx (revision 3972)
>
> +++ osprey/be/cg/sched/sched_heur.cxx (working copy)
>
> @@ -507,8 +507,10 @@
>
>
>
> ARC * arc = ARC_LIST_first (list) ;
>
> switch (ARC_kind (arc)) {
>
> - CG_DEP_PRECHK :
>
> - CG_DEP_PREBR :
>
> +#ifdef TARG_IA64
>
> + case CG_DEP_PRECHK :
>
> +#endif
>
> + case CG_DEP_PREBR :
>
> break ;
>
> default :
>
> ++ fanout ;
>
> Index: osprey/be/cg/orc_intel/sched_heur.cxx
>
> ===================================================================
>
> --- osprey/be/cg/orc_intel/sched_heur.cxx (revision 3972)
>
> +++ osprey/be/cg/orc_intel/sched_heur.cxx (working copy)
>
> @@ -512,8 +512,10 @@
>
>
>
> ARC * arc = ARC_LIST_first (list) ;
>
> switch (ARC_kind (arc)) {
>
> - CG_DEP_PRECHK :
>
> - CG_DEP_PREBR :
>
> +#ifdef TARG_IA64
>
> + case CG_DEP_PRECHK :
>
> +#endif
>
> + case CG_DEP_PREBR :
>
> break ;
>
> default :
>
> ++ fanout ;
>
>
>
> There are two mistakes in this code:
>
> 1. Syntax error: missing the “case”, it will always fall into the
> “default”;
>
> 2. Platform error: missing the macro “#ifdef TARG_IA64”, the
> “CG_DEP_PRECHK” is just defined for IA64.
>
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
