> -----Original Message----- > From: David Coakley [mailto:dcoak...@gmail.com] > Sent: Sunday, August 26, 2012 8:37 PM > To: Gilmore, Doug > Cc: open64-devel > Subject: Re: [Open64-devel] review request for changes to libhugetlbfs > > Hi Doug, > > I reviewed the changes. Here are my comments/questions: > > The formatting (spaces vs. tabs) seems inconsistent, but it's already > that way in the project. It would be nice to clean it up in a > separate update. I can do that. > > Do you run the tests in the 'tests' subdirectory? > tests that should be added for the changes that you made in the second > patch? > > -David We included the tests directory with the original import, but we have not reworked the tests to work with the Open64 driver linking mechanism.
We'll need to investigate that. Thanks, Doug > > On Thu, Aug 23, 2012 at 3:13 PM, Gilmore, Doug <doug.gilm...@amd.com> > wrote: > > I have two changes to libhugetlbfs that I would like to have > reviewed. > > > > The first is just a fix to eliminate a compiler warning. > > > > The second is a change to the library to handle situations where a > > huge page mapping would exhaust the huge page limit. Previously no > > huge pages would be allocated (when mapping ELF segments this failure > > would cause program termination). With these changes, huge pages are > > allocated up to consume the huge page limit, but small pages are used > > to satisfy the rest of the allocation. > > > > Could a gatekeeper review these changes when they have the chance? > > > > Thanks, > > > > Doug > > > > --------------------------------------------------------------------- > --------- > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > Discussions > > will include endpoint security, mobile security and the latest in > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Open64-devel mailing list > > Open64-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/open64-devel > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Open64-devel mailing list Open64-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open64-devel
