The following commit has been merged in the openafs-stable-1_6_x branch:
commit 564573da48f61e5d96d5df017d25a39c930d566f
Author: Simon Wilkinson <[email protected]>
Date: Thu Feb 28 12:15:29 2013 +0000
dumptool: Remove newlines safely
The code currently does
fgets(cmdbuf, ... );
cmdbuf[strlen(cmdbuf - 1)] = '\0';
in order to remove new lines from cmdbuf. Coverity thinks there's
a danger of strlen(cmdbuf) being 0, and thus the strlen being negative.
That shouldn't happen, but if fgets hits EOF midway through a line, we
might get a string that doesn't have a trailing '\n', and end up
removing the wrong character. Tidy this up by checking that the string
isn't 0 length, and that the character we're zapping is a newline.
Caught by coverity (#985430)
Reviewed-on: http://gerrit.openafs.org/9310
Reviewed-by: Derrick Brashear <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Jeffrey Altman <[email protected]>
(cherry picked from commit 8f51502e5f45a43fba130d260813716be894d51e)
Change-Id: Ie165c8e50c4071c07fffa220601c8b5e92ccf815
Reviewed-on: http://gerrit.openafs.org/11026
Reviewed-by: Chas Williams - CONTRACTOR <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/tests/dumptool.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
