The following commit has been merged in the openafs-stable-1_6_x branch:
commit 206d6d9271504cad16326bcb717146ea5b3eed35
Author: Simon Wilkinson <[email protected]>
Date: Wed Feb 27 10:11:21 2013 +0000
libafscp: Can't unlock something we've freed
When we call _StatCleanup on a stored statent structure, it
deletes the mutex, and frees the structure itself. This means it
can't be called with a locked structure as the mutex deletion
will fail, and then we'll try to reference freed memory when we
later unlock that mutex.
Fix this by unlocking the mutex before calling _StatCleanup. This
is safe because the only reference to the structure visible to other
threads must have been deleted by the time we reach this point.
Caught by coverity (#986058, #986059)
Reviewed-on: http://gerrit.openafs.org/9297
Reviewed-by: Derrick Brashear <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Jeffrey Altman <[email protected]>
(cherry picked from commit ce20f1f15103226667bc872378cf9b2e4b3e8cd7)
Change-Id: Id89df6302002224ec2f871f18711e781990f73d3
Reviewed-on: http://gerrit.openafs.org/11024
Reviewed-by: Chas Williams - CONTRACTOR <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/libafscp/afscp_fid.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
