The following commit has been merged in the master branch:
commit d527a8082507bf091f89c7964ce152dfce5d4052
Author: Jeffrey Hutzelman <[email protected]>
Date: Sat Jun 15 18:58:13 2013 -0400
Fix unchecked calls to asprintf
The return value of asprintf() is the number of bytes printed, or -1 if
there
was an error allocating a large enough buffer. In the latter case, the
value
of the result string is undefined, and so it cannot be counted on to be
NULL.
This change fixes numerous places where the result of asprintf is checked
incorrectly (by examining the output pointer and not the return value) or
not
at all.
Change-Id: I9fef14d60c096795d59c42798f3906041fb18c86
Reviewed-on: http://gerrit.openafs.org/9978
Reviewed-by: Benjamin Kaduk <[email protected]>
Reviewed-by: D Brashear <[email protected]>
Tested-by: BuildBot <[email protected]>
src/afsd/afsd_fuse.c | 48 ++++++++++++++++++++++++++-
src/afsweb/apache_afs_plugin.c | 3 +-
src/aklog/aklog.c | 26 ++++++++++----
src/audit/audit-file.c | 6 ++--
src/auth/cellconfig.c | 30 ++++++++++------
src/bozo/bnode.c | 6 ++-
src/bozo/bosoprocs.c | 7 +++-
src/bozo/bosserver.c | 9 +++--
src/budb/procs.c | 4 +-
src/budb/server.c | 19 +++++-----
src/cmd/cmd.c | 24 ++++++-------
src/kauth/krb_tf.c | 4 +-
src/platform/DARWIN/AklogAuthPlugin/aklog.c | 3 +-
src/ptserver/db_verify.c | 3 +-
src/ptserver/ptutils.c | 3 +-
src/sys/rmtsysc.c | 4 +-
src/tests/create-stat.c | 3 +-
src/util/dirpath.c | 3 +-
tests/cmd/command-t.c | 17 ++++++---
tests/common/servers.c | 9 +++--
tests/volser/vos-t.c | 5 ++-
21 files changed, 162 insertions(+), 74 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
