The following commit has been merged in the openafs-stable-1_6_x branch:
commit 264ac76af4e82b0a1e1b27f3f4482100fb1bde20
Author: Benjamin Kaduk <[email protected]>
Date: Wed Apr 22 13:43:43 2015 -0400
kauth: fix clock skew detection
Commit 5b3c1042969daec38ccb260e61d665eda0c713ea changed/removed some
uses of abs() on unsigned time values. While the previous use of abs()
was indeed incorrect, the result wasn't necessarily much better, even
though it built with recent compilers, since it only checked for skew
in one direction.
Define and use a macro to correctly evaluate the conditionals in 64-bit
precision, avoiding C's integer promotion rules which prefer unsigned types
(Date) to signed types of the same width (time_t on 32-bit systems).
Reviewed-on: http://gerrit.openafs.org/11850
Reviewed-by: Stephan Wiesand <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Jeffrey Altman <[email protected]>
(cherry picked from commit 810f0ccd0354dac30af024ca7b5acf3ebabf5f4b)
Change-Id: I29337e1ecd410fcf7733408287930c50c055ff90
Reviewed-on: http://gerrit.openafs.org/11863
Tested-by: BuildBot <[email protected]>
Reviewed-by: Daria Brashear <[email protected]>
Reviewed-by: Benjamin Kaduk <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/kauth/kaprocs.c | 4 ++--
src/kauth/kauth_internal.h | 26 ++++++++++++++++++++++++++
src/kauth/krb_udp.c | 2 +-
3 files changed, 29 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
