The following commit has been merged in the openafs-stable-1_8_x branch: commit 0b1d10fd2535b0059d1e88c23fbd3f60041edc9f Author: Michael Meffie <mmef...@sinenomine.net> Date: Tue Feb 20 11:51:01 2018 -0500
afs: improve -volume-ttl error messages Change the afs call which sets the volume ttl value to return EFAULT instead of EINVAL when given an out of range value for the volume ttl parameter. This is more consistent with the other op codes, which return EFAULT when given an out of range parameter and allows the caller to distinguish between an invalid opcode and a bad parameter. Move the volume ttl range constants to afs_args.h, which is where constants related to the op codes are supposed to be defined. This makes the constants available to the caller in afsd.c as well as the implementation in afs_call.c. Update afsd to print a more sensible error message when the volume ttl set calls fails due to an out of range parameter. Reviewed-on: https://gerrit.openafs.org/12918 Tested-by: BuildBot <build...@rampaginggeek.com> Reviewed-by: Benjamin Kaduk <ka...@mit.edu> (cherry picked from commit 6d74e3d6a1becf86cec30efc2d01a5692167afe1) Change-Id: I2cd86b6fbba31f74862bb902ac94b0874de8afac Reviewed-on: https://gerrit.openafs.org/12936 Tested-by: BuildBot <build...@rampaginggeek.com> Reviewed-by: Mark Vitale <mvit...@sinenomine.net> Reviewed-by: Benjamin Kaduk <ka...@mit.edu> src/afs/afs.h | 4 ---- src/afs/afs_call.c | 2 +- src/afsd/afsd.c | 16 ++++++++++++++-- src/config/afs_args.h | 3 +++ 4 files changed, 18 insertions(+), 7 deletions(-) -- OpenAFS Master Repository _______________________________________________ OpenAFS-cvs mailing list OpenAFS-cvs@openafs.org https://lists.openafs.org/mailman/listinfo/openafs-cvs