The following commit has been merged in the openafs-stable-1_8_x branch:
commit 10157d82c3e8f7cbdec768d92119ed5be126b844
Author: Michael Meffie <[email protected]>
Date: Thu Jun 14 15:01:18 2018 -0400
ubik: do not assign variables in logging argument lists
Several logging statements in ubik contain an assignment statement
within the logging function call argument list, which would set a
variable as side effect of evaluating the function call arguments.
These embedded assignments are problematic since the logging function
calls have been replaced by ViceLog macros, which avoid the overhead of
a function call depending on logging levels.
Remove the embedded assignments within the logging argument lists so the
variables are always set regardless of the logging level.
Reviewed-on: https://gerrit.openafs.org/13211
Tested-by: BuildBot <[email protected]>
Reviewed-by: Joe Gorse <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Marcio Brito Barbosa <[email protected]>
Reviewed-by: Benjamin Kaduk <[email protected]>
(cherry picked from commit 472d6b1ee2f7de415e0fa0f8be0636f86956b6fc)
Change-Id: I230f71022a58445c99adc67ae1b888caa4ce260e
Reviewed-on: https://gerrit.openafs.org/13218
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Mark Vitale <[email protected]>
Reviewed-by: Michael Meffie <[email protected]>
Reviewed-by: Marcio Brito Barbosa <[email protected]>
Reviewed-by: Cheyenne Wills <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/ubik/recovery.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
