The following commit has been merged in the openafs-stable-1_6_x branch:
commit 8da38fa8c6273bd70805740ff61740ab68a1917a
Author: Mark Vitale <[email protected]>
Date: Mon Dec 3 15:33:29 2018 -0800
afs: prevent -settime null pointer dereference
If -settime is enabled and afs_setTimeHost is non-NULL, CkSrv_SetTime
will loop over the conns[] array to find a matching connection for the
afs_setTimeHost. If no match is found, this loop exits with index 'i'
out of bounds for the conns[] array. We then call
CkSrv_MarkUpDown(&conns[i],..), leading to a null pointer dereference.
Add an additional condition so we only call CkSrv_MarkUpDown() if a
matching conn was found.
Introduced by commit 1219b7617ecfe1d9eb0d7ec22f8e2e714732c51d.
Note:
This is a 1.6.x-specific fix, since -settime support has been removed
from 1.8.x and master. Despite this fix, afsd -settime remains
deprecated in OpenAFS 1.6.x.
Change-Id: I958a1b563c5777b3c405e0ff77a7b46d2df80426
Reviewed-on: https://gerrit.openafs.org/13401
Reviewed-by: Michael Meffie <[email protected]>
Reviewed-by: Marcio Brito Barbosa <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/afs/afs_server.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
