The following commit has been merged in the master branch:
commit 929d501421579290ce1d4f9aabe45980e5458a9a
Author: Cheyenne Wills <[email protected]>
Date: Fri Apr 3 15:00:42 2020 -0600
Add more 'fall through' switch comments
Commit a455452d (LINUX 5.3: Add comments for fallthrough switch cases)
added the special /* fall through */ comment to various switch/case
blocks, in order to avoid implicit-fallthrough warnings from causing
the build to fail when building the Linux kernel module.
In this commit, add additional /* fall through */ comments to the rest
of the tree where falling through is intentional. Add a "break;" in one
place in dumptool.c where falling through seems like a mistake, and flag
certain functions as AFS_NORETURN to avoid needing to explicitly break
or fallthrough.
Check for the availability of the -Wimplicit-fallthrough compiler flag
and use it when --enable-checking is set, to prevent additional cases
from creeping into the tree.
Note: the -Wimplicit-fallthrough compiler flag was added in gcc 7.
Change-Id: Iae34e7969606603da8358d7cfa5fd04279b218dc
Reviewed-on: https://gerrit.openafs.org/14125
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Benjamin Kaduk <[email protected]>
Tested-by: BuildBot <[email protected]>
src/butc/dump.c | 3 +--
src/cf/osconf.m4 | 5 +++++
src/cmd/cmd.c | 2 +-
src/opr/jhash.h | 24 ++++++++++++------------
src/tools/dumpscan/afsdump_dirlist.c | 2 +-
src/tools/dumpscan/afsdump_extract.c | 2 +-
src/tools/dumpscan/afsdump_scan.c | 2 +-
src/tools/dumpscan/dumptool.c | 1 +
src/tools/dumpscan/parsevnode.c | 2 +-
src/vol/salvaged.c | 1 +
src/vol/salvsync-server.c | 2 +-
src/vol/volume.c | 3 +++
12 files changed, 29 insertions(+), 20 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
