The following commit has been merged in the openafs-stable-1_8_x branch:
commit eee6a0cddcd31dafb1c67b3cf909496c232bca09
Author: Mark Vitale <[email protected]>
Date: Thu Aug 20 16:09:02 2020 -0400
vol: prevent salvage segfault for orphaned vnode with out-of-range parent
While salvaging a RW volume, salvager may segfault if it encounters an
orphaned directory with a parent vnode that does not exist. For
example, if the large vnode index contains a maximum vnode of 2901, any
parent vnode encountered that is larger than 2901 will result in an
out-of-bounds reference to our vnode essence array, leading to a
segfault or undefined behavior.
Modify the logic to check for out-of-bounds parent vnodes, and log them
rather than segfaulting.
Reviewed-on: https://gerrit.openafs.org/14385
Tested-by: BuildBot <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Benjamin Kaduk <[email protected]>
(cherry picked from commit 750628da77bb71e24ed3061431bbb913ff8d5f72)
Change-Id: Ib0cabde440d59394704967dd3ab2eb73f07aec22
Reviewed-on: https://gerrit.openafs.org/14515
Reviewed-by: Mark Vitale <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Cheyenne Wills <[email protected]>
Reviewed-by: Michael Meffie <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/vol/vol-salvage.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
