The following commit has been merged in the openafs-stable-1_8_x branch:
commit 0cb26f198c6e049171b698098afab82203848434
Author: Michael Meffie <[email protected]>
Date: Fri Sep 3 07:05:36 2021 -0400
ptserver: Fix CreateEntry() stringop-overflow warnings
The CreateEntry() prototype has been fixed to match the function
definition, so callers are expected to provide bounded arrays for the
user or group name. Fix the InitialGroup() macro which is used to set
the built-in names using string literal to avoid stringop-overflow
warnings.
error: ‘CreateEntry’ accessing 64 bytes in a region of size 22
[-Werror=stringop-overflow=]
code = CreateEntry(tt, (name), &temp, /*idflag*/1, flag,
SYSADMINID, SYSADMINID); \
note: in expansion of macro ‘InitialGroup’
InitialGroup(SYSADMINID, "system:administrators");
note: referencing argument 2 of type ‘char *’
note: in a call to function ‘CreateEntry’
CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN],
...
(Repeated for "system:backup", "system:anyuser", "system:authuser",
"system:ptsviewers", and "anonymous".)
Reviewed-on: https://gerrit.openafs.org/14789
Reviewed-by: Benjamin Kaduk <[email protected]>
Tested-by: Benjamin Kaduk <[email protected]>
(cherry picked from commit 7924aecf95bf4918a485a041f2426bd1fa407ac8)
Change-Id: I6e30729f1b24beb1ed1c4b6d9162b347285b7edc
Reviewed-on: https://gerrit.openafs.org/14987
Reviewed-by: Michael Meffie <[email protected]>
Reviewed-by: Mark Vitale <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
Reviewed-by: Marcio Brito Barbosa <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/ptserver/ptutils.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
