The following commit has been merged in the openafs-stable-1_8_x branch:
commit 0b908b7b9b39e36fc1bf98701d7e28d9a7a2f310
Author: Cheyenne Wills <[email protected]>
Date: Fri Nov 4 08:24:09 2022 -0600
rx: Remove event_handler rx_pthread_* counters
The event_handler() function contains several counters that are
set and incremented but are not actually used. Clang-16 is flagging
these with a 'unused-but-set-variable' warning resulting in build errors
when --enable-warnings is used.
rx_pthread.c:136:19: error: variable 'rx_pthread_n_event_expired' set
but not used [-Werror,-Wunused-but-set-variable]
unsigned long rx_pthread_n_event_expired = 0;
Several 'if' statements are used to conditionally set these variables,
but serve no other purpose. These 'if' statements can also be
eliminated.
Remove the unused rx_pthread_* counter variables as well as the
associated 'if' statements. In addition the only purpose of the
'error' variable was to conditionally increment one of the removed
variables, remove the 'error' variable.
These variables have been 'unused but set' since the original commit
from IBM.
Reviewed-on: https://gerrit.openafs.org/15175
Reviewed-by: Benjamin Kaduk <[email protected]>
Reviewed-by: Cheyenne Wills <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Andrew Deason <[email protected]>
(cherry picked from commit f7cb492c7e755ec91226c96cc82ad9f567f01f11)
Change-Id: I4dfdd7e536f6af642789fc51f6f055652c63a46d
Reviewed-on: https://gerrit.openafs.org/15267
Reviewed-by: Michael Meffie <[email protected]>
Tested-by: BuildBot <[email protected]>
Reviewed-by: Stephan Wiesand <[email protected]>
src/rx/rx_pthread.c | 24 +-----------------------
1 file changed, 1 insertion(+), 23 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-cvs
