The following commit has been merged in the master branch:
commit e4d8329619f31c0e234ec0ccd8325b28e33086cf
Author: Andrew Deason <adea...@sinenomine.net>
Date: Fri Jan 3 12:49:56 2025 -0600
lwp: Build src/lwp/test
Make the src/lwp/test directory built by default, by 'cd'ing into 'test'
from src/lwp after building the lwp library. Also fix numerous errors
and warnings to get the directory buildable, including:
- Change many functions to be declared with proper prototypes
- Change many functions and variables to be 'static', since they are
only used inside one compilation unit
- Remove several unused variables
- Include stdlib.h for exit() et al, string.h for strcmp(), fcntl.h for
open(), time.h for localtime() et al, and arpa/inet.h for inet_ntoa().
- Make main() return an int
- Change various signal handler callbacks to be the proper type
- Change LWP_CreateProcess callbacks to be the proper type
- Use %p to print various pointers, instead of 0x%x
- Cast various time-based variables to int for printing with %d
- Remove extra prototypes for IOMGR_Select()
- Give accept() a socklen_t* instead of an int*
- Remove the unused make targets 'system' and 'noversion'
- Update the make rule for the 'test' program to use modern conventions
and use AFS_LDRULE, and avoid passing -p to the compiler
- Remove unnecessary links to util.a
- Remove testlwp.c, which has no main() and isn't linked by
anything else
- In selserver.c:handleWrite(), declare 'c' as an unsigned char (so we can
compare against END_DATA, which is larger than a signed char), and use
'c' as the byte read in from read(), so 'c' is not used uninitialized.
- Change test.c to use LWP_WaitProcess() instead of LWP_MwaitProcess().
LWP_MwaitProcess() has no callers outside of lwp, and was declared
static, effectively making it private, in commit ff988ead4e
(lwp-protoize-20080310).
Also add the built test programs to .gitignore.
Change-Id: I6958a78ae271dbcb865df5d7f30019ba05160b56
Reviewed-on: https://gerrit.openafs.org/16014
Tested-by: BuildBot <build...@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvit...@sinenomine.net>
Reviewed-by: Michael Meffie <mmef...@sinenomine.net>
src/lwp/Makefile.in | 7 +-
src/lwp/test/.gitignore | 4 +
src/lwp/test/Makefile.in | 12 +-
src/lwp/test/selclient.c | 34 ++-
src/lwp/test/selserver.c | 58 ++---
src/lwp/test/selsubs.c | 26 +-
src/lwp/test/test.c | 21 +-
src/lwp/test/test_key.c | 32 +--
src/lwp/test/testlwp.c | 646 -----------------------------------------------
9 files changed, 91 insertions(+), 749 deletions(-)
--
OpenAFS Master Repository
_______________________________________________
OpenAFS-cvs mailing list
OpenAFS-cvs@openafs.org
https://lists.openafs.org/mailman/listinfo/openafs-cvs
