The following commit has been merged in the master branch: commit 3f64facc10e34145f316decf19e24665682f8db9 Author: GANESH CHAUDHARI <gangov...@in.ibm.com> Date: Wed Jan 15 16:31:35 2025 -0500
DARWIN: Skip NULL func ptrs in osi_vnodeops.c In recent versions of Xcode (around the release of macOS 14), clang now reports these former warnings as errors: src/afs/DARWIN/osi_vnodeops.c:163:12: error: incompatible function pointer types initializing 'int (*)(void*)' with an expression of type 'void (*)()' [-Wincompatible-function-pointer-types] {NULL, (void (*)())NULL} ^~~~~~~~~~~~~~~~ src/afs/DARWIN/osi_vnodeops.c:206:12: error: incompatible function pointer types initializing 'int (*)(void*)' with an expression of type 'void (*)()' [-Wincompatible-function-pointer-types] {NULL, (void (*)())NULL} ^~~~~~~~~~~~~~~~ To avoid these errors, simply do not specify the function pointer, and let the rest of the struct value get filled in with zeroes. Also specify a return type for afs_vop_pathconf(), to avoid this error (which clang formerly flagged as a warning): src/afs/DARWIN/osi_vnodeops.c:1841:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] afs_vop_pathconf(ap) ^ [mvitale, adeason: commit message details] Change-Id: Ie856ce059ddb2cf249447b517f66839e35ee5638 Reviewed-on: https://gerrit.openafs.org/16138 Reviewed-by: Michael Meffie <mmef...@sinenomine.net> Reviewed-by: Marcio Brito Barbosa <mbarb...@sinenomine.net> Reviewed-by: Mark Vitale <mvit...@sinenomine.net> Reviewed-by: Andrew Deason <adea...@sinenomine.net> Tested-by: BuildBot <build...@rampaginggeek.com> src/afs/DARWIN/osi_vnodeops.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- OpenAFS Master Repository _______________________________________________ OpenAFS-cvs mailing list OpenAFS-cvs@openafs.org https://lists.openafs.org/mailman/listinfo/openafs-cvs