Joe Buehler wrote:


The overflow of the credentials allocation (over one page) was a performance
hit also -- it causes the code to use vmalloc instead of kmalloc, and vmalloc
has to set up page table entries.  The patch I posted to keep it all on
one page should eliminate this -- not to mention TLB thrashing.

We're running with a similar patch since a few days on some machines without ill effects.

And while you're at it... some 40 lines further down move the

ncreds_inuse--;

line before the "CRED_UNLOCK();" where it belongs.



--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Rainer Toebbicke
European Laboratory for Particle Physics(CERN) - Geneva, Switzerland
Phone: +41 22 767 8985       Fax: +41 22 767 7155
_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

Reply via email to