Sean O'Malley wrote:
> Is it consensus that I can eliminate the ifdef's for fcntl.h in the
> windows code and just include it? (there are a number of places where it
> is ifdef'd to be included for windows or NT4.. )

I've re-read the above sentences several times now.  I'm not sure I
understand which inclusions of fcntl.h you are referring to.  Do you
build the Windows tree?   If not, I would leave it alone.

The Microsoft compilers have included fcntl.h going back at least a
decade.  HAVE_FCNTL_H is defined in the windows config.h file.  So if
you are asking if   #ifdef HAVE_FCNTL_H  can be removed, the answer
from the perspective of Windows is 'yes' but I really must ask "why
bother?"  If the code compiles cleanly now, why remove the #ifdef?

If there are places where fcntl.h is included for one platform and not
for another it may very well be that the reason this is the case is that
the implementations are sufficiently different that the symbols provided
by fcntl.h are simply not used by one or more of them.

Jeffrey Altman


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to