Dale Ghent wrote: > > Because this is a mighty patch, before I submit a bug to RT I'd like > some feedback on it. > > The linked patch touches src/afs/SOLARIS/osi_prototypes.h and > src/afs/SOLARIS/osi_vnodeops.c and removes all compilation warnings > (there were around 30 of them) > > Now, I may have gotten carried away, and that's why I'm posting this > message. > > What this patch does is a few things: > > 1) No more K&R func defs > > 2) No more register typedefs. Sun Studio does register optimization for > us anyway at the optimization level that is used (-O, which Sun Studio > translates to -xO3, which covers register optimization on both sparc and > x86) > > 3) Use shortened typedef names where applicable (ie: "struct vnode foo" > -> "vnode_t foo") > > 4) Get rid of afs_cmp(). It does the same thing as Solaris's fs_cmp() > routine, so use that instead. > > Let me know what any of you think, good or bad. > > http://elektronkind.org/osol/openafs-solaris-vnodeops-cleanup.patch > > /dale
For the most part it looks good to me. Did you forget to remove the K&R function definitions from? afs_GetOnePage gafs_fsync That's all I see. Jeffrey Altman
smime.p7s
Description: S/MIME Cryptographic Signature
