STABLE14-background-fsync-consistency-issues-20090522 introduces ih_refcnt++ in ih_reallyclose(). Now, when ih_refcnt was >= 1 on entry (as it would happen when called from VCloseVolumeHandles_r()) it would end up 2, hence after closing the file descriptor it would simply be decremented but ihP would not be released - we'd end up with an ihandle leak.

Isn't there a

ihP->if_refcnt--;

missing just before the "assert" ?


--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Rainer Toebbicke
European Laboratory for Particle Physics(CERN) - Geneva, Switzerland
Phone: +41 22 767 8985       Fax: +41 22 767 7155
_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

Reply via email to