Sounds great. I started on this patch a few years ago but due to time and job changes I didn't get too far.

As far as the warnings go, are you measuring progress by what gcc has to say with -Wall ? You might want to try Sun's C compiler as well... it tends to gripe a whole lot more, especially when it comes to the K&R style stuff.

/dale

On Jul 6, 2009, at 1:19 PM, Marcus Watts wrote:

At the last workshop, Simon identified "reducing warnings" as a desirable
goal of new patches for openafs.  This is an interesting problem for
large patches, because the # of warnings in openafs is large enough that it's very difficult to sort out were inherited, and which ones are new.

Also, it looks bad when the mainline code is not up to the standard
expected of new code.

Without any more ado, here are some interesting statistics:

                        grep -c         unique source
                        warning:        warning count
openafs 1.5.60(*)       2900            1955
hk28                    5101            3053
hk32                    419             216

stock openafs 1.5.60 needs 2 patches to build in my env.
hk28 and hk32 are "rxk5 against cvs head".
Some warnings occur more than once as various source files
are built different ways.

I expect at some point soonish to have a somewhat simplier
patch that just does this warnings cleanup.

                                -Marcus Watts
_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

Reply via email to