Git/gerrit basics (Windows)
I'd like to submit two trivial changes for the kdfs branch. They're only appropriate to that branch. My main goal is really to learn the git/gerrit process. I plan to make one change, commit and submit. Then make the second change and repeat the process. Some really basic questions: #1 My two changes don't have anything to do with each other but by following the above process, do I establish a dependency so that the 1st change must be applied (approved?) before the 2nd? #2 From: http://www.dementia.org/twiki/bin/view/AFSLore/GitDevelopers Uploading to gerrit ------------------- [...] Secondly, each commit should have a meaningful revision log. The internals of git means that we can't easily edit these before pushing them into the tree, so we'd like you to get them right for us! A commit message should be comprised of a single 'subject' line (which must not end with a full stop), followed by a blank line, followed by one or more paragraphs explaining the purpose of the patch. If it is intended to fix a bug in OpenAFS RT, then the word 'FIXES' followed by the bug number or comma-separated list of bug numbers should be included on a line of its own. The 'LICENSE' keyword can be used to indicate code which is covered under a license other than the IPL, although please speak to a gatekeeper if you intend using this. An example commit message would be Add option to disable syscall probing This adds the --disable-linux-syscall-probing to allow the probing of kernel memory for the syscall table to be disabled at compile time. This helps with Linux architectures which have compile, run or load time issues with syscall probing by providing a band-aid fix until we can improve the configuration logic in this area. The phrase "must not end with a full stop" is confusing to Windows users. (This one anyway) If I make a text file (a.txt) with the above as a guide (on Windows, it'll have <carriage return><line feed>) and supply it to my commit command (in the bash window from msysGit): git commit -F a.txt Will that work? (Minor comment wrt the web page - it took me some time to realize that the above text - under the heading 'upload to gerrit' - is actually part of the git commit activity and doesn't really have anything to do with upload. I had assumed it was something added via a gerrit form presented at the time of commit. Perhaps add some text to put it in context?) #3 I have given the Gerrit server my SSH public key but I'm not sure how msysGit and/or PuTTY and/or ???? is supposed to be configured to make all this work. #4 If the commit stuff works, do I immediately follow that with: git log -p origin/openafs-windows-kdfs-ifs-branch..HEAD git push ssh://gerrit.openafs.org/openafs.git HEAD:refs/for/openafs-windows-kdfs-ifs-branch #5 If the push completes without apparent error, is that the end of the process? Regards, Mickey.
