On Sun, 17 Jan 2010, Simon Wilkinson wrote:
On 17 Jan 2010, at 13:48, Marc Aurele La France wrote:
Any chance of incorporating these into stable?
When we last discussed pullups for 1.4.12, we decided that these were too high risk for that release (the changes appeared very late in the release cycle). MS_NOATIME is sufficiently large that it doesn't appear to conflict with any inode flags, up to and including Linus's current kernel, so there doesn't appear to be a risk associated with not taking them this time round.
Only one more inode flag is needed to create a conflict. Whether or not this occurs before 1.4.13 is released is a risk I gather you are willing to take. I think it's better to be pro-active.
I'd hope that the MS_NOATIME -> S_NOATIME change will land on the 1.4 branch immediately after we release 1.4.12, and thus be in 1.4.13. The change to the super block flags requires more thought, as the impact is potentially far reaching. I'd like to see significantly more testing of that change before we commit to it in a stable release.
I can see your point if, and only if, AFS is ever changed to provide proper access times. Otherwise, I don't see how eliminating pointless traffic on the wire can create a problem.
On a side note, FWIW, the effectiveness of the MS_NOATIME -> S_NOATIME change is dependent on Marc Dionne's 9b37972e610d38a8f45a027d7c10459e29524088 commit (for >= 2.6.32 kernels, that is).
Marc. +----------------------------------+----------------------------------+ | Marc Aurele La France | work: 1-780-492-9310 | | Academic Information and | fax: 1-780-492-1729 | | Communications Technologies | email: [email protected] | | 352 General Services Building +----------------------------------+ | University of Alberta | | | Edmonton, Alberta | Standard disclaimers apply | | T6G 2H1 | | | CANADA | | +----------------------------------+----------------------------------+ XFree86 developer and VP. ATI driver and X server internals. _______________________________________________ OpenAFS-devel mailing list [email protected] https://lists.openafs.org/mailman/listinfo/openafs-devel
