--On Friday, April 15, 2005 10:42:53 PM -0400 chas williams - CONTRACTOR <[EMAIL PROTECTED]> wrote:

In message <[EMAIL PROTECTED]>,Chaskiel M Grundman writes:
--==========E0A3C7D627E180487321==========
I'm not claiming there isn't a problem. I'm claiming that whatever
problem=20 exists is not preallocs that are not being discarded because
of the=20 truncate optimization.

Well, what I said was correct, but you were definitely on the right track. Try this:
(I'll put 'we should try to use dentry_open/filp_close instead of mucking about on our own' on my ever-growing todo list of afs fixes)

Index: LINUX/osi_file.c
===================================================================
RCS file: /cvs/openafs/src/afs/LINUX/osi_file.c,v
retrieving revision 1.23
diff -u -d -r1.23 osi_file.c
--- LINUX/osi_file.c    11 Mar 2005 04:35:42 -0000      1.23
+++ LINUX/osi_file.c    16 Apr 2005 04:12:30 -0000
@@ -65,6 +65,7 @@
    filp->f_mapping = tip->i_mapping;
#endif
#if defined(AFS_LINUX24_ENV)
+    filp->f_mode = FMODE_READ|FMODE_WRITE;
    filp->f_op = fops_get(tip->i_fop);
#else
    filp->f_op = tip->i_op->default_file_ops;



Attachment: p7seCBK5eNcIY.p7s
Description: S/MIME cryptographic signature

Reply via email to