Merged

Thanks Lon

regards
-steve
On Thu, 2007-11-01 at 15:48 -0400, Lon Hohberger wrote:
> Benefits:
> 
> * Calling setsid() creates a new process group, which is probably
> something you actually want with aisexec.
> 
> * Mapping 0/1/2 to /dev/null prevents printfs in the code from causing
> problems (even if they're not "supposed" to be there).  For example, if
> code at some point calls printf() - but file descriptor 1 is an IPC file
> descriptor - bad things happen, I suspect.
> 
> Notes:
> 
> While POSIX defines /dev/null to exist and be a character device, a more
> complete patch would check for those properties.
> 
> setsid() should probably have its return code checked, but I'm not sure
> if doing so would upset things; does it matter (since openais doesn't
> call setsid() now) if it fails?
> 
> -- Lon
> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais

_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to